[Doc] Convert Inputs Tutorial Examples to TS #9183
Merged
+135
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adguernier
approved these changes
Aug 14, 2023
djhi
commented
Aug 14, 2023
| ret = children({ formData, ...rest }); | ||
| ret = children({ | ||
| formData, | ||
| getSource: (scopedSource: string) => scopedSource, |
There was a problem hiding this comment.
This ensures TS users don't have to check that getSource is defined before calling it
fzaninotto
requested changes
Aug 14, 2023
docs/Inputs.md
Outdated
Comment on lines
866
to
884
| const { source, ...rest } = props; | ||
|
|
||
| return ( | ||
| <span> | ||
| <BoundedTextField | ||
| source="lat" | ||
| label="Latitude" | ||
| validate={required()} | ||
| {...rest} | ||
| /> | ||
| | ||
| <BoundedTextField | ||
| source="lng" | ||
| label="Longitude" | ||
| validate={required()} | ||
| {...rest} | ||
| /> | ||
| </span> | ||
| ); |
There was a problem hiding this comment.
weird (too large?) indentation
docs/Inputs.md
Outdated
Comment on lines
833
to
863
| extends Omit< | ||
| TextFieldProps, | ||
| "label" | "helperText" | "onChange" | "onBlur" | "type" | "defaultValue" | ||
| >, | ||
| InputProps {} | ||
|
|
||
| const BoundedTextField = (props: BoundedTextFieldProps) => { | ||
| const { onChange, onBlur, label, ...rest } = props; | ||
| const { | ||
| field, | ||
| fieldState: { isTouched, invalid, error }, | ||
| formState: { isSubmitted }, | ||
| isRequired, | ||
| } = useInput({ | ||
| // Pass the event handlers to the hook but not the component as the field property already has them. | ||
| // useInput will call the provided onChange and onBlur in addition to the default needed by react-hook-form. | ||
| onChange, | ||
| onBlur, | ||
| ...rest, | ||
| }); | ||
|
|
||
| return ( | ||
| <TextField | ||
| {...field} | ||
| label={label} | ||
| error={(isTouched || isSubmitted) && invalid} | ||
| helperText={(isTouched || isSubmitted) && invalid ? error?.message : ""} | ||
| required={isRequired} | ||
| {...rest} | ||
| /> | ||
| ); |
docs/Inputs.md
Outdated
Comment on lines
510
to
525
| <Edit> | ||
| <SimpleForm> | ||
| <SelectInput source="country" choices={toChoices(countries)} /> | ||
| <FormDataConsumer<{ country: string }>> | ||
| {({ formData, ...rest }) => ( | ||
| <SelectInput | ||
| source="cities" | ||
| choices={ | ||
| formData.country ? toChoices(cities[formData.country]) : [] | ||
| } | ||
| {...rest} | ||
| /> | ||
| )} | ||
| </FormDataConsumer> | ||
| </SimpleForm> | ||
| </Edit> |
docs/Inputs.md
Outdated
Comment on lines
464
to
468
| const cities: Record<string, string[]> = { | ||
| USA: ["New York", "Los Angeles", "Chicago", "Houston", "Phoenix"], | ||
| UK: ["London", "Birmingham", "Glasgow", "Liverpool", "Bristol"], | ||
| France: ["Paris", "Marseille", "Lyon", "Toulouse", "Nice"], | ||
| }; |
docs/Inputs.md
Outdated
Comment on lines
471
to
480
| const CityInput = (props: SelectInputProps) => { | ||
| const country = useWatch<{ country: string }>({ name: "country" }); | ||
|
|
||
| return ( | ||
| <SelectInput | ||
| choices={country ? toChoices(cities[country]) : []} | ||
| {...props} | ||
| /> | ||
| ); | ||
| }; |
fzaninotto
approved these changes
Aug 14, 2023
fzaninotto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.