Fix validation errors from resolvers are not translated #9191
Conversation
There was a problem hiding this comment.
Cool, but we really need extensive tests showing that error message translation occurs once and only once in the 3 following cases:
- per input validation
- form-wide validation with
validate - form-wide validation with
resolvers
These tests may be scattered around several components, I'm not sure. A central test for this matter would be welcome.
|
Added to |
| return <>{translate(message, { _: message, ...args })}</>; | ||
| return <>{translate(message, args)}</>; | ||
| } | ||
|
|
||
| return <>{translate(errorMessage as string, { _: errorMessage })}</>; | ||
| return <>{translate(errorMessage as string)}</>; |
There was a problem hiding this comment.
To allow warnings on missing translations
There was a problem hiding this comment.
But then it's a regression, as missing translation warnings will now get logged in the console while they were not in master.
If this is only for the purpose of tests, you can enable warning on missing message in the parameters of the polyglotI18nProvider options (https://airbnb.io/polyglot.js/#options-overview). And if it doesn't work, you'll have to use a spy i18nProvider.
There was a problem hiding this comment.
The fact that it silenced the missing translations warnings was actually a reggresion and was contradictory to the expected and documented behavior.
fzaninotto
deleted the
fix-validation-translations-when-using-resolvers
branch
Fixes #9084