Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add screenshot and screencast for <ReferenceManyToManyInput> and <ReferenceManyToManyField> #9204

Merged
merged 9 commits into from
Aug 24, 2023
Merged

[Doc] Add screenshot and screencast for <ReferenceManyToManyInput> and <ReferenceManyToManyField> #9204

merged 9 commits into from
Aug 24, 2023

Conversation

adguernier
Copy link
Contributor

Problem

ReferenceManyToManyInput and ReferenceManyToManyField have no screenshot in the documentation.

Solution

Add screenshots related to the example code of each components in documentation

djhi
djhi requested changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshot does not have the correct width. It should be 960px

@adguernier
Copy link
Contributor Author

adguernier commented Aug 21, 2023 •
edited
Loading

The screenshot does not have the correct width. It should be 960px

Same for screencast ?

@djhi
Copy link
Collaborator

djhi commented Aug 21, 2023

The screenshot does not have the correct width. It should be 960px

Same for screencast ?

Not sure but I guess so. Please compare with existing screencasts

@adguernier
Copy link
Contributor Author

The screenshot does not have the correct width. It should be 960px

Same for screencast ?

Not sure but I guess so. Please compare with existing screencasts

Compared: screen-casts have different size 🤷

fzaninotto
fzaninotto requested changes Aug 22, 2023
View reviewed changes
@adguernier adguernier added the RFR Ready For Review label Aug 23, 2023
slax57
slax57 requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that the <Admin> in the videos is cropped to the right and at the bottom. Can't you resize the <Admin> frame to fit the dimensions of the video?

@slax57 slax57 added this to the 4.13.2 milestone Aug 24, 2023
@slax57 slax57 merged commit ead74aa into master Aug 24, 2023
@slax57 slax57 deleted the doc-screen-for-reference-many-to-many-input-and-field branch August 24, 2023 08:08
@slax57 slax57 changed the title Doc screenshot and screencast for <ReferenceManyToManyInput> and <ReferenceManyToManyField> [Doc] Add screenshot and screencast for <ReferenceManyToManyInput> and <ReferenceManyToManyField> Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto requested changes

@djhi djhi djhi requested changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.13.2
Development

Successfully merging this pull request may close these issues.
4 participants
@adguernier @djhi @fzaninotto @slax57