Skip to content

[WIP] removed query options from ListGuesser #9335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] removed query options from ListGuesser #9335

wants to merge 1 commit into from

Conversation

dinaco
Copy link

@dinaco dinaco commented Oct 5, 2023 •
edited
Loading

relates to issue #9318

@dinaco
removed query options from ListGuesser
136b84f 
Signed-off-by: Dino Marchiori <dino.marchiori@ctw.bmwgroup.com>
@dinaco dinaco changed the title removed query options from ListGuesser [RFC] removed query options from ListGuesser Oct 5, 2023
@dinaco dinaco changed the title [RFC] removed query options from ListGuesser [RFR] removed query options from ListGuesser Oct 5, 2023
@fzaninotto
Copy link
Member

You're reverting the change introduced in #7605, which fixed a bug (#7599), so you're effectively reintroducing the bug.

@dinaco dinaco changed the title [RFR] removed query options from ListGuesser [WIP] removed query options from ListGuesser Oct 8, 2023
@dinaco
Copy link
Author

dinaco commented Oct 8, 2023

You're reverting the change introduced in #7605, which fixed a bug (#7599), so you're effectively reintroducing the bug.

Ok, I'll look into it again

@dinaco dinaco closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dinaco @fzaninotto