Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <CreateButton> forces full lodash in bundle #9385

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Oct 24, 2023

Problem

The build of the CRM demo takes 500kB more (unzipped) in the latest release.

image

Solution

To let the bundler tree-shake lodash, never import from the main package.

@fzaninotto fzaninotto added the RFR Ready For Review label Oct 24, 2023
@slax57 slax57 added this to the 4.15.2 milestone Oct 24, 2023
@slax57 slax57 merged commit fc28021 into master Oct 24, 2023
@slax57 slax57 deleted the fix--lodash-tree-shaking branch October 24, 2023 13:25
@slax57 slax57 changed the title [Doc] Fix <CreateButton> forces full lodash in bundle Fix <CreateButton> forces full lodash in bundle Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants