Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp demo page and add EE demo #9430

Merged
merged 14 commits into from
Nov 13, 2023
Merged

Revamp demo page and add EE demo #9430

merged 14 commits into from
Nov 13, 2023

Conversation

erwanMarmelab
Copy link
Contributor

@erwanMarmelab erwanMarmelab commented Nov 8, 2023

Problem

The page in https://marmelab.com/react-admin/Demos.html doesn’t mention the EE demo, but it’s a great one!

The section should highlight the most important features.

It’s a good opportunity to revamp the demos page, e.g. following https://mui.com/toolpad/examples/ design

Solution

Revamp the demo page, add EE demo, and highlight important features

Todo

  • Revamp demo page
  • Add EE demo
  • Highlight important features
  • Adapt mobile version
  • Fix video
  • Change iframe to video for the 1st demo

Screenshots

Before

image

After

image

@erwanMarmelab erwanMarmelab added the WIP Work In Progress label Nov 8, 2023
<div class="card">
<iframe src="https://player.vimeo.com/video/474999017?autoplay=1&loop=1&muted=1" frameborder="0" allowfullsreen></iframe>
<div class="content-card">
<a href="#e-commerce" class="no-decoration">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit lost when I click the links anchor. I would have imagined dedicated pages for each sections instead, that explain further what they demonstrate.
What do you think about it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about the number of pages this will create. won't it overload the navbar?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I disagree with @adguernier , IMO the anchors are fine and we should keep them that way.
To be discussed with @fzaninotto then.

erwanMarmelab and others added 2 commits November 10, 2023 11:39
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
@erwanMarmelab erwanMarmelab removed WIP Work In Progress DNM Do Not Merge labels Nov 10, 2023
erwanMarmelab and others added 2 commits November 10, 2023 11:42
Co-authored-by: adrien guernier <adrien@marmelab.com>
Co-authored-by: adrien guernier <adrien@marmelab.com>
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new layout is rad!

I think the anchor experience is fine and we shouldn't add more pages.

However, there are two adjustments you need to make:

  1. The cards shouldn't show an autoplay video of each demo, because these videos are too small, and it makes the page change too much. Instead, the cards should only show a still image extracted from each demo, and the section below would show the video.
  2. The video for the Ee edition is too large to be leaded as a mp4 file. We need to host it in a video provider (Vimeo). I'll host it with the Marmelab account and we'll adjust the embed.

@fzaninotto fzaninotto merged commit 277fb01 into master Nov 13, 2023
@fzaninotto fzaninotto deleted the revamp-demos-page branch November 13, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants