[TypeScript] Fix <MenuItemLink> prop type should omit placeholder
#9555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Jan 4, 2024
fzaninotto
approved these changes
Jan 4, 2024
djhi
approved these changes
Jan 4, 2024
|
Thanks! |
slax57
changed the title
<MenuItemLink> type by omitting placeholder prop<MenuItemLink> prop type should omit placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this merge request DefinitelyTyped/DefinitelyTyped#67170 introduced into @types/react 18.2.43,
placeholderprop is no longer inHTMLAttributes.Somehow since 18.2.43 the
<MenuItemLink>requires us to pass theplaceholderprop to the<a>tag below, where there are no such prop defined in MDN DocsCloses #9507