Fix fetchJSON
adds useless Content-Type header for empty requests
#9613
+59
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Fastify on the backend, and it refuses
DELETE
requests sent from react-admin'sra-data-json-server
.It is because
fetchUtils.fetchJson
is setting theContent-Type
header toapplication/json
, even with an empty body like in the delete requests. The function that is setting the header iscreateHeadersFromOptions
infetch.ts
.It is not against the RFCs to do so, but it just breaks Fastify, and it makes little sense to send a Content-Type with a body that doesn't adhere to the content type: an empty body isn't valid json.
This pull request fixes the issue and adds new unit tests to ensure there is no regression.
yarn test-unit -- ./packages/ra-core/src/dataProvider/fetch.spec.ts
passes.I guess the alternatives are:
'null'
in it)ra-data-json-server
package (and other data providers which are using DELETE with no body) to specify a body.I thought fixing the
createHeadersFromOptions
option was the cleanest