Add a default unique id for useInput
#9788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Apr 29, 2024
| @@ -132,7 +132,7 @@ export const useInput = <ValueType = any>( | |||
| }; | |||
|
|
|||
| return { | |||
| id: id || finalSource, | |||
| id: id || `use-input-${finalSource}`, | |||
There was a problem hiding this comment.
We should leverage useId if id is not provided
djhi
reviewed
Apr 29, 2024
| id: id || finalSource, | ||
| id: | ||
| id || | ||
| `${defaultId.substring(1, defaultId.length - 1)}-${finalSource}`, |
There was a problem hiding this comment.
It was to be more readable.
Applied
fzaninotto
requested changes
Apr 29, 2024
docs/useInput.md
Outdated
| | `format` | Optional | `Function` | - | A function to format the value from the record to the input value | | ||
| | `parse` | Optional | `Function` | - | A function to parse the value from the input to the record value | | ||
| | `validate` | Optional | `Function` | `Function[]` | - | A function or an array of functions to validate the input value | | ||
| | `id` | Optional | `string` | `:r[input number]:` | The id of the input | |
There was a problem hiding this comment.
too much details here. Just use autogenerated for the default value
| id: id || finalSource, | ||
| id: | ||
| id || | ||
| `${defaultId.substring(1, defaultId.length - 1)}-${finalSource}`, |
There was a problem hiding this comment.
I don't understand why you substring
|
You should probably add a section in the upgrade guide as this is a breaking change |
djhi
reviewed
Apr 30, 2024
Comment on lines
+931
to
+936
| ## Inputs default ids are auto-generated | ||
|
|
||
| In previous versions, the input default id was the source of the input. In v5, inputs defaults ids are auto-generated with [React useId()](https://react.dev/reference/react/useId). | ||
|
|
||
| **Tip:** You still can pass an id as prop of any [react-admin input](./Inputs.md) or use a [reference](https://fr.react.dev/reference/react/useRef). | ||
|
|
There was a problem hiding this comment.
What's the impact for users? You should mention that if they relied on this for tests, they should pass the id
There was a problem hiding this comment.
something like this ?
djhi
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do
Closes #9534