[TypeScript] Make types more strict in ra-ui-materialui, part III #9795
Conversation
| @@ -1,7 +1,8 @@ | |||
| import { useEffect } from 'react'; | |||
| import { useStore } from '../store'; | |||
| import { debounce } from 'lodash'; | |||
There was a problem hiding this comment.
This change is unrelated to the PR, but I noticed that the bundles for the demos were embarking the entire lodash, so I figured I'd fix this regression.
| @@ -62,7 +62,7 @@ describe('<useList />', () => { | |||
| { id: 2, title: 'world' }, | |||
| { id: 1, title: 'hello' }, | |||
| ], | |||
| error: undefined, | |||
There was a problem hiding this comment.
this is to make the output compatible with the ListControllerResult, which is using useQueryResult signature. In it, the empty error is null, not undefined.
| @@ -485,7 +485,7 @@ export interface ListControllerLoadingResult<RecordType extends RaRecord = any> | |||
| error: null; | |||
| isPending: true; | |||
| } | |||
| export interface ListControllerLoadingErrorResult< | |||
There was a problem hiding this comment.
this name didn't make sense
| @@ -1,11 +1,11 @@ | |||
| id,reference,date,customer_id,basket.product_id,basket.quantity,total_ex_taxes,delivery_fees,tax_rate,taxes,total,status,returned | |||
| 408,5TFGTA,2021-04-23T02:07:38.273Z,17,87,1,108.28,5.38,0.2,22.73,136.39,ordered,false | |||
There was a problem hiding this comment.
The customer_ids weren't pointing to actual records in the customers csv, which caused warnings on import
| @@ -46,8 +44,8 @@ export const SimpleFormIterator = (inProps: SimpleFormIteratorProps) => { | |||
| }); | |||
| const { | |||
| addButton = <DefaultAddItemButton />, | |||
| removeButton = <DefaultRemoveItemButton />, | |||
There was a problem hiding this comment.
moved default values to SimpleFormIteratorItem, where they make more sense
| @@ -185,7 +186,7 @@ export const CheckboxGroupInput: FunctionComponent<CheckboxGroupInputProps> = pr | |||
| [allChoices, formOnChange, formOnBlur, optionValue, value] | |||
| ); | |||
|
|
|||
| if (isPending && (!allChoices || allChoices.length === 0)) { | |||
| if (isPending) { | |||
| @@ -72,12 +72,7 @@ export const useReferenceArrayFieldController = < | |||
| const notify = useNotify(); | |||
| const value = get(record, source); | |||
| const { meta, ...otherQueryOptions } = queryOptions; | |||
|
|
|||
| const ids = useMemo(() => { | |||
There was a problem hiding this comment.
chore: 'useMemo' is imported line 2 but no more used, we may could remove it
| formGroups && | ||
| formGroupName != null && |
There was a problem hiding this comment.
thought (non-blocking): Not sure, but may we add finalSource in the condition ?
| formGroups && | |
| formGroupName != null && | |
| formGroups && | |
| finalSource && | |
| formGroupName != null && |
There was a problem hiding this comment.
finalSource is always defined because source is required (see ArrayInputProps and InputProps).
| formGroups && | ||
| formGroupName != null && |
There was a problem hiding this comment.
thought (non-blocking): Same here
| formGroups && | |
| formGroupName != null && | |
| formGroups && | |
| finalSource && | |
| formGroupName != null && |
| document.elementFromPoint(x.current, y.current) === null | ||
| ? selectedItem | ||
| : document.elementFromPoint(x.current, y.current).closest('li'); | ||
| : // @ts-ignore TypeScript is drunk |
There was a problem hiding this comment.
Nope, extract the result of document.elementFromPoint in a variable
| @@ -97,7 +98,7 @@ export const useSupportCreateSuggestion = ( | |||
|
|
|||
| if (finalValue?.id === createValue || finalValue === createValue) { | |||
| if (!isValidElement(create)) { | |||
| const newSuggestion = await onCreate(filter); | |||
| const newSuggestion = await onCreate!(filter); | |||
There was a problem hiding this comment.
If I'm not mistaken, onCreate could be null because is not mandatory in SupportCreateSuggestionOptions interface.
Reduces strictNullChecks compilation errors in ra-ui-materialui/src/inputs directory from 109 to 50