Add a global ErrorBoundary #9799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Apr 30, 2024
docs/Admin.md
Outdated
| | `darkTheme` | Optional | `object` | `default DarkTheme` | The dark theme configuration | | ||
| | `defaultTheme` | Optional | `boolean` | `false` | Flag to default to the light theme | | ||
| | `disableTelemetry` | Optional | `boolean` | `false` | Set to `true` to disable telemetry collection | | ||
| | `error` | Optional | `(props: FallbackProps) => Component` | - | A React component rendered in the content area in case of error | |
There was a problem hiding this comment.
the type is too precise and therefore takes too much space. Use Component as for the other similar props
djhi
reviewed
May 2, 2024
There was a problem hiding this comment.
I wonder whether we should also remove the existing ErrorBoundary from the Layout now that we have this new one. @fzaninotto?
|
I think we should keep the one on the layout, because it allows users to navigate using the menu after an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some errors raised in the AppBar or the Side Menu break the application in an ugly way. The error boundary in the default layout doesn't work in this case because it is designed to replace only the main content and keep rendering the navigation menu to let users change location.
Solution
Add a global ErrorBoundary before rendering the layout to catch errors in the Chrome.
TODO
Layout.mdAdmin.md/ra-core/src/core/CoreAdminUI.tsx/ra-core/src/core/CoreAdmin.tsx/ra-ui-materialui/src/AdminUI.tsx/react-admin/src/Admin.tsxCoreAdminUI.tsx