-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade query-string to v9 #9812
Conversation
@@ -28,7 +28,7 @@ module.exports = { | |||
'/packages/create-react-admin/templates', | |||
], | |||
transformIgnorePatterns: [ | |||
'[/\\\\]node_modules[/\\\\](?!(@hookform)/).+\\.(js|jsx|mjs|ts|tsx)$', | |||
'[/\\\\]node_modules[/\\\\](?!(@hookform|query-string|decode-uri-component|filter-obj|split-on-first)/).+\\.(js|jsx|mjs|ts|tsx)$', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that mean that react-admin users will have to do the same in their jest configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is specific to Jest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly my question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently have three libraries in our yarn.lock for query string parsing/formatting:
- qs (used by storybook)
- query-string
- querystring (used by fetch-mock)
Maybe we could use one already there from our deps?
Sorry for the noise. |
No worries happy to help any time, Done. |
@@ -687,7 +687,7 @@ Here is an example implementation, that you can use as a base for your own Data | |||
|
|||
```js | |||
import { fetchUtils } from 'react-admin'; | |||
import { stringify } from 'query-string'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do that? I see no upgrade guide in query-string for that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this package just export default now
Thanks for your comment. Can you rebase to fix the merge conflicts? |
Done but one of the checks is failing and there's no log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a temporary error, I relaunched the job and it passed. Good job!
No description provided.