Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for React PropTypes #9851

Merged
merged 7 commits into from
May 16, 2024
Merged

Remove support for React PropTypes #9851

merged 7 commits into from
May 16, 2024

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented May 16, 2024

React-admin will no longer support (deprecated) React PropTypes. We encourage you to switch to TypeScript to type component props.

docs/Upgrade.md Outdated Show resolved Hide resolved
slax57 and others added 2 commits May 16, 2024 15:07
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com>
@slax57
Copy link
Contributor Author

slax57 commented May 16, 2024

There seem to be an issue in a test. Back to WIP.

@slax57 slax57 added RFR Ready For Review and removed WIP Work In Progress labels May 16, 2024
@slax57
Copy link
Contributor Author

slax57 commented May 16, 2024

Should be good now. Back to RFR.

Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love a good red PR!

@fzaninotto fzaninotto merged commit f702fa5 into next May 16, 2024
13 checks passed
@fzaninotto fzaninotto deleted the remove-propTypes branch May 16, 2024 14:32
@fzaninotto fzaninotto added this to the 5.0.0 milestone May 16, 2024
@fzaninotto fzaninotto mentioned this pull request May 16, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants