-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Next] Backport changes from master #9923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Doc] Update ra-tree documentation
docs: changed ressource to resource
docs: remove trailing slash on url
Added Genezio as a data provider
When filters with a complex object as defaultValue the "empty value" was not considered empty by the UI. This commit ensure we don't display empty filters on the UI. Refs: #9893
Add test to ensure correction. Refs: #9893
…-link [Doc] Add link to Codesandbox of the simple demo
Fix `<SelectInput resettable>` does not reset the value
…reset Fix filters with complex object are not removed from the UI
[Doc] Clarify `<SaveButton transform>` usage
…fter-remove Fix ArrayInput ghost error after removing scalar item
slax57
commented
Jun 17, 2024
Comment on lines
+17
to
+25
export interface IMessages | ||
extends Record<string, string | ((options?: any) => string) | IMessages> {} | ||
|
||
export const testI18nProvider = ({ | ||
translate, | ||
messages, | ||
}: { | ||
translate?: I18nProvider['translate']; | ||
messages?: Record<string, string | ((options?: any) => string)>; | ||
messages?: IMessages; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to make this change because otherwise TypeScript (rightfully) complains when messages
contains nested keys.
Example:
messages: {
resources: {
posts: {
title: 'Post'
}
}
}
fzaninotto
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.