-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve extra query parameters in List view #9933
Preserve extra query parameters in List view #9933
Conversation
Please add unit tests showing that your change fixes the problem. |
Also, I consider this a new feature, so please target the |
@fzaninotto thanks for the review. I added the unit test. may I ask to treat this as a bug fix please🙏🏻, because it is hard for me to migrate my app to RA 5 now. I already have plans to migrate to RA 5 once it become the official release but migrating now especially without the official docs using V5 I am afraid my colleagues (whom most of them are backend engineers) will be a bit confused. I can also open another PR for this to be treated as a feature and merge it to |
you know what, you can treat it as a feature. I may use this to speed up the migration to v5 and we became early adopter. |
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.2...6.2.3) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
04511f2
to
eff0424
Compare
eff0424
to
6011cee
Compare
@fzaninotto please let me know if anything further from my side is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Problem
addressing #9932
Solution
remove unnecessary query param sanitisation to keep any custom params in the url.
How To Test
run
make test
Additional Checks
master
for a bugfix, ornext
for a featureAlso, please make sure to read the contributing guidelines.