Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve extra query parameters in List view #9933

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

Nilegfx
Copy link
Contributor

@Nilegfx Nilegfx commented Jun 19, 2024

Problem

addressing #9932

Solution

remove unnecessary query param sanitisation to keep any custom params in the url.

How To Test

run make test

Additional Checks

  • The PR targets master for a bugfix, or next for a feature
  • The PR includes unit tests (if not possible, describe why)
  • The PR includes one or several stories (if not possible, describe why)
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@fzaninotto
Copy link
Member

Please add unit tests showing that your change fixes the problem.

@fzaninotto
Copy link
Member

Also, I consider this a new feature, so please target the next branch for this PR.

@Nilegfx
Copy link
Contributor Author

Nilegfx commented Jun 19, 2024

@fzaninotto thanks for the review.

I added the unit test.

may I ask to treat this as a bug fix please🙏🏻, because it is hard for me to migrate my app to RA 5 now. I already have plans to migrate to RA 5 once it become the official release but migrating now especially without the official docs using V5 I am afraid my colleagues (whom most of them are backend engineers) will be a bit confused.

I can also open another PR for this to be treated as a feature and merge it to next branch if this will help you.

@Nilegfx
Copy link
Contributor Author

Nilegfx commented Jun 19, 2024

you know what, you can treat it as a feature. I may use this to speed up the migration to v5 and we became early adopter.

@Nilegfx Nilegfx changed the base branch from master to next June 19, 2024 13:24
dependabot bot and others added 5 commits June 19, 2024 15:37
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@6.2.2...6.2.3)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@Nilegfx Nilegfx force-pushed the keep-custom-query-params-in-list-view branch 2 times, most recently from 04511f2 to eff0424 Compare June 19, 2024 14:13
@Nilegfx
Copy link
Contributor Author

Nilegfx commented Jun 20, 2024

@fzaninotto please let me know if anything further from my side is needed.

@slax57 slax57 self-requested a review June 25, 2024 12:28
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slax57 slax57 added the RFR Ready For Review label Jun 25, 2024
@slax57 slax57 added this to the 5.1.0 milestone Jun 25, 2024
@slax57 slax57 changed the title remove query param sanetization from list view url when using setFilter Preserve extra query parameters in List view Jun 25, 2024
@slax57 slax57 merged commit 9862354 into marmelab:next Jun 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants