-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix <ReferenceArrayInput>
should forward queryOptions
to getMany
#9954
Conversation
<ReferenceArrayInput>
should forward queryOptions
to getMany
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🙂
Unfortunately this seems to throw a TS error at build time. Can you check?
5befd7c
to
72f9067
Compare
I rebased on 4.x, is it better? |
Thanks for the rebase. It seems I do not have push permissions on your branch, so I published the required change here: d7ed98e Can you apply it to your branch? Thanks. |
cherry-picked and pushed |
Thanks! 🙂 I'm sorry I didn't realize this before, but it would be nice to also update the documentation to specify that the Can you update it? 🙏 |
ok :) see latest commit, hopefully it' only in one place? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think we're good 🙂 (apart from this last suggestion)
Co-authored-by: Jean-Baptiste Kaiser <jbaptiste.kaiser@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
please release this fix in v4 |
@lumpov Sorry, this is a new feature and v4 is feature freeze. You'll have to upgrade to v5 if you need this feature. |
fix for #9953