Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Fix ReferenceField Props type is confusing #9972

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[TypeScript] Fix ReferenceField Props type is confusing #9972

merged 1 commit into from
Jul 4, 2024

Conversation

fzaninotto
Copy link
Member

This confusing type was introduced by 43f8e72#diff-bcb8a95735be07f07a5fe05f577626392756002e0c6350fcc0e1e8a17dbea8d9, at a moment when source was optional. It's no longer necessary.

@fzaninotto fzaninotto added the RFR Ready For Review label Jul 3, 2024
@djhi djhi added this to the 5.0.4 milestone Jul 4, 2024
@djhi djhi merged commit 5d6b19b into master Jul 4, 2024
14 checks passed
@djhi djhi deleted the fix-reference-field-type branch July 4, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
5.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi