Improving correctness of the formatInTimeZone close to the DST threshold
#247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asennikov
changed the title
formatInTimeZone close to DST thresholdformatInTimeZone close to the DST threshold
asennikov
force-pushed
the
master
branch
2 times, most recently
from
b8cc570 to
706b06f
Compare
This was referenced Aug 24, 2023
|
Hi! |
I would ask @marnusw |
marnusw
added a commit
that referenced
this pull request
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
Fixes #228
Using the original date for populating the correct replaced timezone token ensures that the DST threshold is applied to the original date, not a pre-modified date used for further formatting.