Skip to content

Commit

Permalink
Drop support for VS Code < 1.43 (#154)
Browse files Browse the repository at this point in the history
* Require VS Code >= 1.43

* Don't test against Node for Electron 6

* [ci skip] Update CHANGELOG.md
  • Loading branch information
yhatt authored Jul 25, 2020
1 parent c4df74c commit bc76f1c
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 16 deletions.
10 changes: 0 additions & 10 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,6 @@ jobs:
steps:
- audit

unit-electron6:
executor:
name: node
version: '12.4.0'
steps:
- test

unit-electron7:
executor:
name: node
Expand All @@ -107,9 +100,6 @@ workflows:
test:
jobs:
- audit
- unit-electron6:
requires:
- audit
- unit-electron7:
requires:
- audit
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [Unreleased]

### Breaking

- VS Code >= 1.43 ([Electron 7](https://code.visualstudio.com/updates/v1_43#_electron-70-update)) is now required ([#154](https://github.com/marp-team/marp-vscode/pull/154))

### Changed

- Upgrade to [Marp Core v1.2.2](https://github.com/marp-team/marp-core/releases/v1.2.2) and [Marp CLI v0.20.0](https://github.com/marp-team/marp-cli/releases/v0.20.0) ([#151](https://github.com/marp-team/marp-vscode/pull/151))
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"url": "https://github.com/marp-team/marp-vscode"
},
"engines": {
"vscode": "^1.40.0"
"vscode": "^1.43.0"
},
"main": "./lib/extension.js",
"icon": "images/icon.png",
Expand Down Expand Up @@ -226,7 +226,7 @@
"@types/jest": "^26.0.7",
"@types/lodash.debounce": "^4.0.6",
"@types/markdown-it": "^10.0.1",
"@types/vscode": "~1.40.0",
"@types/vscode": "~1.43.0",
"@types/yaml": "^1.9.7",
"builtin-modules": "^3.1.0",
"codecov": "^3.7.2",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -804,10 +804,10 @@
resolved "https://registry.yarnpkg.com/@types/unist/-/unist-2.0.3.tgz#9c088679876f374eb5983f150d4787aa6fb32d7e"
integrity sha512-FvUupuM3rlRsRtCN+fDudtmytGO6iHJuuRKS1Ss0pG5z8oX0diNEw94UEL7hgDbpN94rgaK5R7sWm6RrSkZuAQ==

"@types/vscode@~1.40.0":
version "1.40.0"
resolved "https://registry.yarnpkg.com/@types/vscode/-/vscode-1.40.0.tgz#47d19e9e32da512c986f579fe6afbc8d3e6e0c55"
integrity sha512-5kEIxL3qVRkwhlMerxO7XuMffa+0LBl+iG2TcRa0NsdoeSFLkt/9hJ02jsi/Kvc6y8OVF2N2P2IHP5S4lWf/5w==
"@types/vscode@~1.43.0":
version "1.43.0"
resolved "https://registry.yarnpkg.com/@types/vscode/-/vscode-1.43.0.tgz#22276e60034c693b33117f1068ffaac0e89522db"
integrity sha512-kIaR9qzd80rJOxePKpCB/mdy00mz8Apt2QA5Y6rdrKFn13QNFNeP3Hzmsf37Bwh/3cS7QjtAeGSK7wSqAU0sYQ==

"@types/yaml@^1.9.7":
version "1.9.7"
Expand Down

0 comments on commit bc76f1c

Please sign in to comment.