Simplify Marp integration by using independent instance #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored
extendMarkdownItto be simplify Marp integration by using independent instance.The core of VS Code Markdown integration has not supposed to extend by the other extensions. We tried to implement better experience of configuration, but it seems to be difficult in the approach as same as until now.
So I changed a logic for extend drastically. We will swap rendering methods to redirect to the proper
markdown-itinstance: VSCode's or Marp's.We become to use independent instance Marp. Thus, the extend logic will be much simpler and it would never trigger new conflication with the other extensions. In other words, user can no longer extend Marp renderer by using VSCode extensions.