Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaks option for Marp Markdown #22

Merged
merged 6 commits into from
Apr 10, 2019
Merged

Add breaks option for Marp Markdown #22

merged 6 commits into from
Apr 10, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Apr 7, 2019

This PR adds markdown.marp.breaks configuration to control rendering of line-breaks in Marp Markdown separately from VS Code's configuration. It allows 3 options:

  • off: Ignore line-breaks in rendered Marp preview.
  • on: Show line-breaks in rendered Marp preview.
  • inherit: Use inherited setting from markdown.preview.breaks.

To suit to Marp Core and the other tools, the default value is on.

Resolves #16.

breaks

ToDo

  • Fix warning in getting configuration of markdown.preview.breaks (It should specify resource)
    • 👉 VS Code's Markdown extension cannot get current resource URI. We use the passed option to markdown-it instead of configuration value.

@yhatt yhatt merged commit c0e42ce into master Apr 10, 2019
@yhatt yhatt deleted the breaks-option branch April 10, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant