Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle export into non-file scheme #269

Merged
merged 7 commits into from
Jul 30, 2021
Merged

Handle export into non-file scheme #269

merged 7 commits into from
Jul 30, 2021

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Jul 29, 2021

The path for exporting slide may become non file scheme (e.g. vscode-local if used together with Remote extension). This PR is adding support of the export command for non-file scheme.

  • If the output path had file scheme, Marp CLI tries to export into specified path as same as current.
  • If the output path had other URI scheme, Marp CLI tries to export into tmpfile, and copy it to specified path via vscode.workspace.fs.copy.
    • In this case, Marp for VS Code will not try to open the output file after exporting.
    • When the URI scheme has marked as readonly, Marp for VS Code will notify users that and not try to export.

An exported slide that has processed in the remote container can save into local file system correctly.

Resolve #262.

@yhatt yhatt changed the title Handle export command into non-file scheme Handle export into non-file scheme Jul 29, 2021
package.json Outdated Show resolved Hide resolved
@yhatt yhatt merged commit 3513bbf into main Jul 30, 2021
@yhatt yhatt deleted the export-to-non-local-fs branch July 30, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle the export command while non-file schema
1 participant