Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up build for Web extension #283

Merged
merged 22 commits into from
Sep 3, 2021
Merged

Set up build for Web extension #283

merged 22 commits into from
Sep 3, 2021

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Aug 30, 2021

This is the first try to make a build for VS Code Web extension.

Closes #281.

Confirmed

  • Action button and commands
  • IntelliSense for Marp Markdown
  • Marp preview
    • While debugging, it looks like that VS Code is ignored extendMarkdownIt contribution point.
  • Custom themes
  • Export
    • We have no plans to support an export command on the Web for now. Export command is same meaning as the frontend of Marp CLI, and CLI does not assume working on the Web.

ToDo

  • Set up build system for Web extension
    • webpack
      • We figured rollup does not suit for Web bundle that requires complex settings for Node polyfills.
    • Isomorphic modules
      • Don't use Node.js modules as possible (remaining: path, os -> polyfilled)
        • fs -> workspace.fs with Uri.file()
      • Replace node-fetch to fetch-ponyfill (It still will use node-fetch on the Node.js environment)

@yhatt yhatt marked this pull request as ready for review September 3, 2021 18:06
@yhatt yhatt merged commit 3db6777 into main Sep 3, 2021
@yhatt yhatt deleted the web-extension branch September 3, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for github.dev
1 participant