Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direction keyword for advanced background #138

Merged
merged 7 commits into from
Mar 13, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Mar 12, 2019

This PR adds the direction keyword for advanced background, vertical and horizontal to control aligning direction of multiple backgrounds.

The default direction is horizontal. By adding vertical keyword, user can stack background images vertically.

This feature is based on request in #137.

NOTE: The mentioned core request is splitting contents to multiple layer. We have not planned to implement it, because we afraid to unexpected layout for theme author.

Regular backgrounds

![bg vertical](https://placekitten.com/1000/600)
![bg](https://placekitten.com/800/700)
![bg](https://placekitten.com/900/900)
horizontal (default) vertical
horizontal vertical

with Split background

![bg right vertical](https://placekitten.com/1000/600)
![bg](https://placekitten.com/800/700)
![bg](https://placekitten.com/900/900)
horizontal (default) vertical
right-hotizontal right-vertical

ToDo

  • Update docs to explain direction keywords

@yhatt
Copy link
Member Author

yhatt commented Mar 12, 2019

CI is blocked by a vulnerability of dependency. We have to update dependencies at first in another PR.

@yhatt yhatt merged commit 03606b8 into master Mar 13, 2019
@yhatt yhatt deleted the advanced-bg-direction-keyword branch March 13, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant