Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment result of average() function #179

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Conversation

okinawaa
Copy link
Contributor

@okinawaa okinawaa commented Dec 2, 2022

Thank you for providing a good library.
There was a difference between the test code and the actual annotation, so I fixed it.

average docs

image

// average.spec.ts

 it.each([
      [[1, 2, 3, 4, 5], 3],
      [[], NaN],
    ])(
      "should return the average of the given elements",
      function (nums, result) {
        expect(average(nums)).toEqual(result);
      },
    );

    it("should be able to be used as a curried function in the pipeline", function () {
      const res = pipe([1, 2, 3, 4, 5], average);
      expect(res).toEqual(3);
    });

Thank you😎

Copy link
Member

@ppeeou ppeeou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution :) 👍

@ppeeou ppeeou merged commit 9316758 into marpple:main Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants