Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Simple Wikipedia Demo error - missing imports #215

Closed
georgewritescode opened this issue Dec 10, 2022 · 3 comments
Closed

[BUG] Simple Wikipedia Demo error - missing imports #215

georgewritescode opened this issue Dec 10, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@georgewritescode
Copy link
Contributor

Describe the bug
Missing imports in Simple Wikipedia Demo

errors:
NameError: name 'math' is not defined for numpy, math, copy
TypeError: Index.add_documents() got an unexpected keyword argument 'batch_size'

To Reproduce

  • Run Marqo
  • Run python3 simple_wiki_demo.py

Expected behavior
Missing imports error

Desktop (please complete the following information):

  • OS: MacOS on M-series Macbook air (M2)
  • Marqo version: 0.0.8

Additional context
Will be submitting a PR shortly
@georgewritescode georgewritescode added the bug Something isn't working label Dec 10, 2022
@jn2clark
Copy link
Contributor

Thanks @georgewritescode ! A PR would be great. This was my fault, I did not update the demo :(

georgewritescode added a commit to georgewritescode/marqo that referenced this issue Dec 10, 2022
@georgewritescode
Fix imports and client erros in Simple Wikipedia Demo
73381f6 
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fixes to Simple Wikipedia Demo error
- Add missing imports
- Remove unused pytorch import
- Change batch size params to align to the current Python client

Associated with this issue: marqo-ai#215
@georgewritescode georgewritescode mentioned this issue Dec 10, 2022
Merged
3 tasks
@georgewritescode
Copy link
Contributor Author

@jn2clark , no problem 👍
PR created #216

pandu-k pushed a commit that referenced this issue Dec 13, 2022
@georgewritescode
Fix imports and client erros in Simple Wikipedia Demo (#216)
86bfdc5 
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fixes to Simple Wikipedia Demo error
- Add missing imports
- Remove unused pytorch import
- Change batch size params to align to the current Python client

Associated with this issue: #215
@jn2clark
Copy link
Contributor

closing for now. fixed in #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@georgewritescode @jn2clark