Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backwards compatibility error with get_settings #1003

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

RaynorChavez
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    users switching from 2.11 to 2.12 and using the get_settings api endpoint will get an error

{
  "message": "[{\"loc\": [\"videoPreprocessing\"], \"msg\": \"none is not an allowed value\", \"type\": \"type_error.none.not_allowed\"}, {\"loc\": [\"audioPreprocessing\"], \"msg\": \"none is not an allowed value\", \"type\": \"type_error.none.not_allowed\"}]",
  "code": "invalid_argument",
  "type": "invalid_request",
  "link": ""
}

other api endpoints unaffected

  • What is the new behavior (if this is a feature change)?
    2.11 indexes upgraded to 2.12 will no longer get this error

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@farshidz farshidz merged commit a8bafb2 into releases/2.12 Oct 14, 2024
3 checks passed
@farshidz farshidz deleted the raynor/2.12.3 branch October 14, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants