-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Python to 3.9 #1006
Open
vicilliar
wants to merge
24
commits into
mainline
Choose a base branch
from
joshua/upgrade-to-python-3.9
base: mainline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade Python to 3.9 #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_encoding.py and test_large_model_encoding.py test against hardcoded vectors stored in json files
vicilliar
had a problem deploying
to
marqo-test-suite
October 15, 2024 18:56
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
October 15, 2024 18:56
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
October 15, 2024 18:57
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 05:31
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 05:31
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 05:32
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 05:46
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 05:46
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 05:48
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 05:51
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 05:51
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 05:53
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 06:45
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 06:53
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 06:54
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 06:56
— with
GitHub Actions
Error
vicilliar
temporarily deployed
to
marqo-test-suite
October 16, 2024 08:33
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
marqo-test-suite
October 16, 2024 08:33
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
marqo-test-suite
October 16, 2024 08:34
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
marqo-test-suite
October 21, 2024 09:29
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
November 19, 2024 05:48
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
November 19, 2024 05:48
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
November 19, 2024 05:48
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
November 19, 2024 06:00
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
November 19, 2024 06:00
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
marqo-test-suite
November 19, 2024 06:00
— with
GitHub Actions
Error
vicilliar
temporarily deployed
to
marqo-test-suite
November 19, 2024 06:10
— with
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
marqo-test-suite
November 19, 2024 06:10
— with
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
marqo-test-suite
November 19, 2024 06:11
— with
GitHub Actions
Inactive
wanliAlex
previously approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vicilliar
had a problem deploying
to
marqo-test-suite
November 20, 2024 04:58
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
marqo-test-suite
November 20, 2024 04:58
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
marqo-test-suite
November 20, 2024 05:00
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
marqo-test-suite
November 20, 2024 23:52
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
marqo-test-suite
November 20, 2024 23:52
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
November 20, 2024 23:52
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
November 21, 2024 02:36
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
marqo-test-suite
November 21, 2024 02:36
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
marqo-test-suite
November 21, 2024 02:36
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
marqo-test-suite
November 21, 2024 07:34
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
marqo-test-suite
November 21, 2024 07:34
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
marqo-test-suite
November 21, 2024 07:36
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Version upgrade
What is the current behavior? (You can also link to an open issue here)
Python 3.8 is being used
What is the new behavior (if this is a feature change)?
Marqo-base image 44 will be used (has Python 3.9 and Vespa 8.431.32)
Python 3.9 will be used for image and tests.
Vector regression tests for all encoding models have been added
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Performance and compatibility testing have been done here
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements