Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video/Audio File Size limits in search, embed, and add docs #1012

Merged
merged 16 commits into from
Dec 3, 2024
Merged

Video/Audio File Size limits in search, embed, and add docs #1012

merged 16 commits into from
Dec 3, 2024

Conversation

RaynorChavez
Copy link
Member

@RaynorChavez RaynorChavez commented Oct 17, 2024 •
edited
Loading

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    add docs has a hard 100 mb limit to video and audio files
    search and embed have a 20s timeout for video and audio files

  • What is the new behavior (if this is a feature change)?
    we introduce a new env var that allows the user to globally set their desired video and audio file size threshold (default 370 MB)

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    yes

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@RaynorChavez RaynorChavez changed the title Video/Audio File Size limits in search and embed Video/Audio File Size limits in search, embed, and add docs Nov 27, 2024
wanliAlex
wanliAlex requested changes Dec 2, 2024
View reviewed changes
src/marqo/tensor_search/add_docs.py Outdated Show resolved Hide resolved
src/marqo/api/configs.py Show resolved Hide resolved
src/marqo/s2_inference/clip_utils.py Show resolved Hide resolved
wanliAlex
wanliAlex approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@wanliAlex wanliAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaynorChavez RaynorChavez merged commit a262ede into mainline Dec 3, 2024
9 checks passed
@RaynorChavez RaynorChavez deleted the raynor/video_audio_size_limit branch December 3, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papa99do papa99do papa99do left review comments

@wanliAlex wanliAlex wanliAlex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaynorChavez @papa99do @wanliAlex