Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image download headers regresison and fix png image issue #1022

Merged
merged 31 commits into from
Oct 25, 2024

Conversation

wanliAlex
Copy link
Collaborator

@wanliAlex wanliAlex commented Oct 23, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    This is a regression as image_download_headers. Private images can not be downloaded even if users passes image_download_headers. Thi is a regression.

We also find an issue that when providing weighted queries, Marqo can not accept a queries with more than 2 modalities. An 500 error is raised:

res = mq.index("test").search({"test": 1, "https://marqo-k400-video-test-dataset.s3.amazonaws.com/videos/-LenAZs2OFM_000002_000012.mp4": 1, "https://raw.githubusercontent.com/marqo-ai/marqo/mainline/examples/ImageSearchGuide/data/image1.jpg": 1})


Languagebind models can't take `.png` images as input.
  • What is the new behavior (if this is a feature change)?
  • We introduce a new parameter, mediaDownloadHears and will deprecate imageDownloadHeaders in the future.
  • We fix the regression. Users can add documents with private images by providing media_download_headers.
  • Fix the bug that users can not provide more than 2 modalities in the weighted query.
  • Fix the bug that languagebind models can't take .png images as input. It can not index .png models correctly.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@wanliAlex wanliAlex changed the title Fix image download headers regresison Fix image download headers regresison and fix png image issue Oct 25, 2024
@wanliAlex wanliAlex merged commit 5c372dd into mainline Oct 25, 2024
12 checks passed
@wanliAlex wanliAlex deleted the li/image-download-headers branch October 25, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants