-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the validation regressions for unstructured indexes #1034
Merged
papa99do
merged 1 commit into
releases/2.13
from
yihan/fix-unstructured-list-validation-213
Nov 18, 2024
Merged
Fix the validation regressions for unstructured indexes #1034
papa99do
merged 1 commit into
releases/2.13
from
yihan/fix-unstructured-list-validation-213
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papa99do
temporarily deployed
to
marqo-test-suite
November 7, 2024 22:49
— with
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
November 7, 2024 22:49
— with
GitHub Actions
Inactive
papa99do
commented
Nov 8, 2024
src/marqo/core/unstructured_vespa_index/unstructured_add_document_handler.py
Show resolved
Hide resolved
papa99do
commented
Nov 8, 2024
src/marqo/core/unstructured_vespa_index/unstructured_add_document_handler.py
Show resolved
Hide resolved
papa99do
commented
Nov 8, 2024
papa99do
temporarily deployed
to
marqo-test-suite
November 8, 2024 00:22
— with
GitHub Actions
Inactive
RaynorChavez
approved these changes
Nov 8, 2024
wanliAlex
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/marqo/core/unstructured_vespa_index/unstructured_add_document_handler.py
Show resolved
Hide resolved
farshidz
reviewed
Nov 18, 2024
src/marqo/core/unstructured_vespa_index/unstructured_add_document_handler.py
Show resolved
Hide resolved
src/marqo/core/unstructured_vespa_index/unstructured_add_document_handler.py
Show resolved
Hide resolved
src/marqo/core/unstructured_vespa_index/unstructured_add_document_handler.py
Show resolved
Hide resolved
src/marqo/core/unstructured_vespa_index/unstructured_add_document_handler.py
Show resolved
Hide resolved
src/marqo/core/unstructured_vespa_index/unstructured_add_document_handler.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes
Related Python client changes (link commit/PR here)
No
Related documentation changes (link commit/PR here)
No
Other information:
Please check if the PR fulfills these requirements