Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the validation regressions for unstructured indexes #1034

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

papa99do
Copy link
Collaborator

@papa99do papa99do commented Nov 7, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • List type of unstructured index is not validated correctly. numeric list is not captured in the validation and a generic error is raised when converting it to Vespa array type, causing the whole batch to fail
  • Custom vector field not included in tensor fields will be silently ignored
  • What is the new behavior (if this is a feature change)?
  • Numeric list type is captured earlier in the validation phase, which only cause the individual doc to fail, with a proper error message in the response
  • Custom vector field not included in tensor fields will cause the whole batch to fail.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Yes

  • Related Python client changes (link commit/PR here)
    No

  • Related documentation changes (link commit/PR here)
    No

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@papa99do papa99do changed the base branch from mainline to releases/2.13 November 7, 2024 22:48
@papa99do papa99do marked this pull request as ready for review November 8, 2024 00:17
Copy link
Collaborator

@wanliAlex wanliAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@papa99do papa99do merged commit 65029cf into releases/2.13 Nov 18, 2024
9 checks passed
@papa99do papa99do deleted the yihan/fix-unstructured-list-validation-213 branch November 18, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants