Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change back to use pull_requst trigger #1048

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

papa99do
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Process fix

  • What is the current behavior? (You can also link to an open issue here)

  • we use pull_request_target trigger so that the forked PR can trigger the build run with Action secrets. However, this caused inconvenece to PRs making change to the GH actions. They cannot be tested properly in PR builds (GH always triggers the build with workflow yaml on the base branch)
  • What is the new behavior (if this is a feature change)?
  • we change back to use pull_request trigger so GH action on the PR branch is used in PR builds. Please note this means community forked PR won't be able to trigger build correctly again. We will find another solution to this issue
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    No

  • Related Python client changes (link commit/PR here)
    No

  • Related documentation changes (link commit/PR here)
    NO

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

Copy link
Collaborator

@wanliAlex wanliAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@papa99do papa99do merged commit 293247f into mainline Nov 21, 2024
18 checks passed
@papa99do papa99do deleted the yihan/fix-gh-action-pr-trigger branch November 21, 2024 05:42
papa99do added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants