Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed permission issue that's causing backwards compatibility test run to fail & made logic to run prepare mode tests more robust #1049

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

adityabharadwaj198
Copy link
Member

@adityabharadwaj198 adityabharadwaj198 commented Nov 21, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Compatibility tests are not running in marqo-ai/marqo repo due to providing overly permissive permission (i.e write-all) (https://github.com/marqo-ai/marqo/actions/runs/11951180519). These tests were earlier run on a forked repo and worked fine: (https://github.com/adityabharadwaj198/marqo/actions/runs/11927467398). While investigating the issue I found that some logic of how we run our prepare method could be improved, so I've fixed that as well.

  • What is the new behavior (if this is a feature change)?
    Marqo compatibility tests will run in marqo-ai/marqo repo w/o failures

  1. (https://github.com/marqo-ai/marqo/actions/runs/11954641816/)
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Added sample test run link:

    1. (https://github.com/marqo-ai/marqo/actions/runs/11954641816/)
  • Related Python client changes (link commit/PR here)

  • None

  • Related documentation changes (link commit/PR here)

  • None

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@adityabharadwaj198 adityabharadwaj198 changed the title aditya/fix-folder-to-ignore Fix permission issue that's causing backwards compatibility test run to fail Nov 21, 2024
@adityabharadwaj198 adityabharadwaj198 changed the title Fix permission issue that's causing backwards compatibility test run to fail Fixed permission issue that's causing backwards compatibility test run to fail & made logic to run prepare mode tests more robust Nov 21, 2024
@adityabharadwaj198 adityabharadwaj198 merged commit 69ce3d3 into mainline Nov 22, 2024
22 of 23 checks passed
@adityabharadwaj198 adityabharadwaj198 deleted the aditya/fix-folder-to-ignore branch November 22, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants