-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed permission issue that's causing backwards compatibility test run to fail & made logic to run prepare mode tests more robust #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityabharadwaj198
changed the title
aditya/fix-folder-to-ignore
Fix permission issue that's causing backwards compatibility test run to fail
Nov 21, 2024
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 09:08
— with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 21, 2024 09:08
— with
GitHub Actions
Failure
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 21, 2024 09:08
— with
GitHub Actions
Error
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 09:11
— with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 21, 2024 10:15
— with
GitHub Actions
Failure
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 10:19
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 10:21
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-build-environment
November 21, 2024 10:21
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 10:21
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 10:31
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 13:52
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 13:52
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 13:52
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 13:54
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-build-environment
November 21, 2024 13:55
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 21, 2024 14:03
— with
GitHub Actions
Inactive
adityabharadwaj198
changed the title
Fix permission issue that's causing backwards compatibility test run to fail
Fixed permission issue that's causing backwards compatibility test run to fail & made logic to run prepare mode tests more robust
Nov 21, 2024
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 22, 2024 04:03
— with
GitHub Actions
Failure
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 22, 2024 04:03
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 22, 2024 04:04
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 22, 2024 04:07
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-build-environment
November 22, 2024 04:10
— with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 22, 2024 04:20
— with
GitHub Actions
Inactive
wanliAlex
approved these changes
Nov 22, 2024
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 22, 2024 06:02
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Compatibility tests are not running in marqo-ai/marqo repo due to providing overly permissive permission (i.e write-all) (https://github.com/marqo-ai/marqo/actions/runs/11951180519). These tests were earlier run on a forked repo and worked fine: (https://github.com/adityabharadwaj198/marqo/actions/runs/11927467398). While investigating the issue I found that some logic of how we run our prepare method could be improved, so I've fixed that as well.
What is the new behavior (if this is a feature change)?
Marqo compatibility tests will run in marqo-ai/marqo repo w/o failures
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Added sample test run link:
Related Python client changes (link commit/PR here)
None
Related documentation changes (link commit/PR here)
None
Other information:
Please check if the PR fulfills these requirements