Open clip model support #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes passe the updated test. |
jn2clark
reviewed
Oct 9, 2022
jn2clark
reviewed
Oct 10, 2022
jn2clark
reviewed
Oct 10, 2022
jn2clark
reviewed
Oct 10, 2022
…els to test open_clip
jn2clark
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Implementing the clip models from open_clip
https://github.com/mlfoundations/open_clip
What is the current behavior? (You can also link to an open issue here)
we only support clip models from openai
What is the new behavior (if this is a feature change)?
we can use clip models from open_clip
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
users need to install open_clip_torch package
Other information:
I update the requirements.txt and set_up.py files to support open_clip_torch.