Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added max fields and doc size limits #135

Merged
merged 8 commits into from
Oct 23, 2022
Merged

Added max fields and doc size limits #135

merged 8 commits into from
Oct 23, 2022

Conversation

pandu-k
Copy link
Collaborator

@pandu-k pandu-k commented Oct 21, 2022

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behaviour? (You can also link to an open issue here)
No way to limit the size of documents and the max number of fields per index.

What is the new behaviour (if this is a feature change)?
A size of document limit and the max number of fields per index limit are now settable by env var.

The doc size limit has a default size of 100k bytes.

Localhost Marqo-OS requests no longer raise warnings.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Non-breaking data model changes:

  • Text fields no longer produce the automatically created keyword field, in the parent doc
  • Very large fields get their keyword (for filtering the facet object) ignored, rather than Marqo-OS preventing the doc being indexed

Other information:
Ran tox

@pandu-k pandu-k requested a review from jn2clark October 21, 2022 07:03
@pandu-k pandu-k merged commit d8fb142 into mainline Oct 23, 2022
@pandu-k pandu-k deleted the limits_2 branch October 23, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants