Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing non_tensor_fields to _batch #167

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Conversation

pandu-k
Copy link
Collaborator

@pandu-k pandu-k commented Nov 9, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    _batch_request not getting non_tensor_field info

  • What is the new behavior (if this is a feature change)?
    _batch_reques getting non_tensor_field info

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    Added some extra tests for non-tensor-fields

Copy link
Contributor

@VitusAcabado VitusAcabado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pandu-k pandu-k merged commit 76adc10 into mainline Nov 9, 2022
@pandu-k pandu-k deleted the patch_non_tensor_field branch November 9, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants