-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timing Logging Enrichment #242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandu-k
requested changes
Dec 19, 2022
added Marqo-os search time to both lexical and tensor search. added total search time log. updated descriptions of search to say whether multi or normal search is used.
vicilliar
had a problem deploying
to
marqo-test-suite
December 21, 2022 05:30
— with
GitHub Actions
Failure
pandu-k
reviewed
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comment
vicilliar
temporarily deployed
to
marqo-test-suite
December 21, 2022 11:39
— with
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
marqo-test-suite
December 21, 2022 18:03
— with
GitHub Actions
Inactive
pandu-k
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Observability feature.
What is the current behavior? (You can also link to an open issue here)
Timing logs are not output at every step of Marqo add_documents and search. They are only returned to the client via
processingTimeMS
.What is the new behavior (if this is a feature change)?
Breaks down and adds explicit timing logs to relevant parts of the Marqo process. Replaces existing timing devices with
timeit.default_timer
, due to it being faster to instantiate thandatetime.datetime
.The following parts now have explicit timing logs (by batch):
logger.debug
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes.
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements