Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow list fields as metadata in Marqo (#277) #312

Merged
merged 7 commits into from
Feb 13, 2023

Conversation

tomhamer
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This change means that marqo is able to accept non-tensor list fields. This is useful so that users can do "contains" operations on list metadata. [ENHANCEMENT] Support list and dictionary data structures #277

  • What is the current behavior? (You can also link to an open issue here)
    Currently, marqo does not allow users to add lists as metadata.

  • What is the new behavior (if this is a feature change)?
    Marqo allows users to add metadata as non_tensor fields, meaning they are available for filtering and lexical search

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    pending succesful unit test run, handing this off for completion for now by @pandu-k

  • Related Python client changes (link commit/PR here)
    none

  • Related documentation changes (link commit/PR here)
    pending

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@pandu-k
Copy link
Collaborator

pandu-k commented Feb 11, 2023

There is no explicit Array type, in OS: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/array.html

@pandu-k
Copy link
Collaborator

pandu-k commented Feb 12, 2023

To test (for Image index and reg. index):
- Lexical search of fields (as a searchable and non searchable attr) [DONE]
- Filtering (lexical and non lexical search) [DONE]
- Add-docs: check the document structure (list appears in chunks, but has no dedicated chunks)

@pandu-k
Copy link
Collaborator

pandu-k commented Feb 12, 2023

@pandu-k
Copy link
Collaborator

pandu-k commented Feb 12, 2023

@pandu-k pandu-k merged commit 3f8f71f into mainline Feb 13, 2023
@pandu-k pandu-k deleted the tom-lists-as-metadata branch February 13, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants