Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add punkt tokenizer download into Dockerfile #346

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Add punkt tokenizer download into Dockerfile #346

merged 3 commits into from
Mar 10, 2023

Conversation

Jeadie
Copy link
Contributor

@Jeadie Jeadie commented Feb 24, 2023

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Change to improve timing on start-up

What is the current behavior? (You can also link to an open issue here)

  • On startup, a series of initialisations are run link, including loading nltk tokenizer support link

What is the new behavior (if this is a feature change)?

  • Downloading and storing the tokenizers/punkt data into the Docker image.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • No

Have unit tests been run against this PR? (Has there also been any additional testing?)

  • No

Related Python client changes (link commit/PR here)

  • No

Related documentation changes (link commit/PR here)

  • No

Other information:

  • No

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@pandu-k
Copy link
Collaborator

pandu-k commented Feb 26, 2023

It looks like it is still being downloaded during startup: https://github.com/marqo-ai/marqo/actions/runs/4277065612/jobs/7445617872#step:8:4902

@Jeadie Jeadie temporarily deployed to marqo-test-suite February 26, 2023 23:46 — with GitHub Actions Inactive
@Jeadie Jeadie temporarily deployed to marqo-test-suite February 27, 2023 06:15 — with GitHub Actions Inactive
@vicilliar vicilliar temporarily deployed to marqo-test-suite March 2, 2023 07:22 — with GitHub Actions Inactive
@vicilliar vicilliar temporarily deployed to marqo-test-suite March 2, 2023 08:48 — with GitHub Actions Inactive
@pandu-k pandu-k merged commit 9d1c851 into mainline Mar 10, 2023
@pandu-k pandu-k deleted the jack/punkt branch March 10, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants