Absolute model cache paths #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests running: https://github.com/marqo-ai/marqo/actions/runs/4380985145 |
pandu-k
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
pandu-k
changed the title
pandu-k
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
wanliAlex
approved these changes
Mar 10, 2023
pandu-k
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
|
Rerunning unit tests: https://github.com/marqo-ai/marqo/actions/runs/4382008075 |
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
the model cache dir is relative, and therefore unpredictable. This can lead to the interpreter not being able to load a model if the CWD changes.
What is the new behavior (if this is a feature change)?
The model cache directories are now consistent and relative to the Marqo root.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
In progress
Please check if the PR fulfills these requirements