Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large Model unit tests work with slashes #439

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Conversation

vicilliar
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Large model unit tests don't work with slashes in branch names

  • What is the new behavior (if this is a feature change)?
    They now run on the proper branch

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Yes

Proof correct branch is checked out:
image
https://github.com/marqo-ai/marqo/actions/runs/4698284684/jobs/8330418887

@pandu-k pandu-k merged commit 97dfeba into mainline Apr 16, 2023
@pandu-k pandu-k deleted the joshua/largemodel-branch branch April 16, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants