Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the error message in memory limit #499

Merged
merged 2 commits into from
May 31, 2023
Merged

Change the error message in memory limit #499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
320f472
fix memory
wanliAlex May 31, 2023
962d40c
fix memory
wanliAlex May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/marqo/s2_inference/s2_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,9 +287,9 @@ def _check_memory_threshold_for_model(device: str, model_size: Union[float, int]
f"without device cache check. This might break down Marqo if too many models are loaded.")
if model_size > threshold:
raise ModelCacheManagementError(
f"You are trying to load a model with size = `{model_size}` into device = `{device}`, which is larger than the device threshlod = `{threshold}`."
f"You are trying to load a model with size = `{model_size}` into device = `{device}`, which is larger than the device threshold = `{threshold}`. "
f"Marqo CANNOT find enough space for the model. Please change the threshold by adjusting the environment variables.\n"
f"You can find more detailed information at `https://docs.marqo.ai/0.0.17/Advanced-Usage/configuration/`.")
f"You can find more detailed information at `https://docs.marqo.ai/0.0.21/Advanced-Usage/configuration/`.")
return (used_memory + model_size) < threshold


Expand Down