Patch multimodal so broken document is not indexed #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
reviewed
Oct 31, 2023
There was a problem hiding this comment.
Thanks Li! 2 comments:
- There seems to be some formatting your IDE applies to the test file, which adds a lot of diffs, making it a bit harder to read
- Great job adding new tests. Do these new unit tests fail, without the bug fix?
- For the new tests: should we check the response body of the add_documents call, where a document isn't indexed properly, to make sure the error message appears as expected?
- For the new tests: can we have a case where some documents get indexed successfully but other documents, that have broken URL or vectorise breaks, don't get indexed successfully?
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
approved these changes
Oct 31, 2023
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
patch a bug in multimodal that indexes the broken documents
What is the current behavior? (You can also link to an open issue here)
a broken document is still indexed
What is the new behavior (if this is a feature change)?
broken document will not be indexed
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Have unit tests been run against this PR? (Has there also been any additional testing?)
running
Related Python client changes (link commit/PR here)
no
Related documentation changes (link commit/PR here)
no
Other information:
no
Please check if the PR fulfills these requirements