-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch unstructured bool #709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
had a problem deploying
to
marqo-test-suite
January 12, 2024 00:22
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
January 31, 2024 08:19
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
January 31, 2024 09:18
— with
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
January 31, 2024 22:58
— with
GitHub Actions
Failure
farshidz
temporarily deployed
to
marqo-test-suite
January 31, 2024 22:58
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
February 4, 2024 23:35
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
February 4, 2024 23:35
— with
GitHub Actions
Inactive
farshidz
requested changes
Feb 5, 2024
wanliAlex
temporarily deployed
to
marqo-test-suite
February 5, 2024 02:52
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
February 5, 2024 02:52
— with
GitHub Actions
Inactive
farshidz
requested changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed please check structured tests and consider doing a full comparison of schemas rather than individual asserts
wanliAlex
had a problem deploying
to
marqo-test-suite
February 5, 2024 04:29
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
February 5, 2024 04:29
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
February 5, 2024 04:33
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
February 5, 2024 04:33
— with
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
February 5, 2024 06:24
— with
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
February 5, 2024 06:24
— with
GitHub Actions
Failure
farshidz
previously approved these changes
Feb 6, 2024
wanliAlex
had a problem deploying
to
marqo-test-suite
February 6, 2024 04:06
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
February 6, 2024 04:06
— with
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
February 6, 2024 04:18
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
February 6, 2024 04:18
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
February 6, 2024 04:20
— with
GitHub Actions
Inactive
farshidz
approved these changes
Feb 6, 2024
farshidz
temporarily deployed
to
marqo-test-suite
February 6, 2024 22:51
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
February 6, 2024 22:51
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
February 6, 2024 22:51
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
February 6, 2024 22:52
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
February 6, 2024 22:52
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
February 6, 2024 22:52
— with
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
February 6, 2024 22:52
— with
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
February 6, 2024 22:52
— with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
we patch the unstructured bool behavior so users can filter on the string bool field
{"string_bool": "true"}
What is the current behavior? (You can also link to an open issue here)
we can't filter the string_bool field(str)
bool field is not returned in the search results
What is the new behavior (if this is a feature change)?
users can filter on the string bool field
{"string_bool": "true"}
bool field will be returned in the search results
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Have unit tests been run against this PR? (Has there also been any additional testing?)
no
Related Python client changes (link commit/PR here)
no
Related documentation changes (link commit/PR here)
no
Other information:
no
Please check if the PR fulfills these requirements