Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch unstructured bool #709

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Patch unstructured bool #709

merged 12 commits into from
Feb 6, 2024

Conversation

wanliAlex
Copy link
Collaborator

@wanliAlex wanliAlex commented Jan 12, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    we patch the unstructured bool behavior so users can filter on the string bool field {"string_bool": "true"}

  • What is the current behavior? (You can also link to an open issue here)
    we can't filter the string_bool field(str)
    bool field is not returned in the search results

  • What is the new behavior (if this is a feature change)?
    users can filter on the string bool field {"string_bool": "true"}
    bool field will be returned in the search results

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    no

  • Related Python client changes (link commit/PR here)
    no

  • Related documentation changes (link commit/PR here)
    no

  • Other information:
    no

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

Copy link
Collaborator

@farshidz farshidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed please check structured tests and consider doing a full comparison of schemas rather than individual asserts

farshidz
farshidz previously approved these changes Feb 6, 2024
@wanliAlex wanliAlex merged commit d7bfb6b into mainline Feb 6, 2024
21 of 22 checks passed
@wanliAlex wanliAlex deleted the li/patch-unstructured-bool branch February 6, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants