Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 429 for Vespa timeouts #758

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Return 429 for Vespa timeouts #758

merged 8 commits into from
Feb 7, 2024

Conversation

farshidz
Copy link
Collaborator

@farshidz farshidz commented Feb 7, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Improvement

  • What is the current behavior? (You can also link to an open issue here)
    500 error on Vespa timeout

  • What is the new behavior (if this is a feature change)?
    429 throttled error when we get a timeout error from Vespa

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Yes

  • Related Python client changes (link commit/PR here)
    No

  • Related documentation changes (link commit/PR here)
    No

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

vicilliar
vicilliar previously approved these changes Feb 7, 2024
@farshidz farshidz merged commit b2125a8 into mainline Feb 7, 2024
27 of 31 checks passed
@farshidz farshidz deleted the farshid/vespa-timeouts branch February 7, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants