Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch connectionreseterror error in image download #829

Merged
merged 4 commits into from
May 6, 2024

Conversation

wanliAlex
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    if an ConnectionResetError is raised, we will have 500 errors

  • What is the new behavior (if this is a feature change)?
    we now catch it

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    running

  • Related Python client changes (link commit/PR here)
    no

  • Related documentation changes (link commit/PR here)
    no

  • Other information:
    no

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

Copy link
Collaborator

@farshidz farshidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at thread results and raise an internal error (500) if a thread has failed so bugs in the threads aren't so hard to catch in the future

src/marqo/s2_inference/clip_utils.py Outdated Show resolved Hide resolved
@wanliAlex wanliAlex requested a review from farshidz May 6, 2024 03:38
@farshidz farshidz temporarily deployed to marqo-test-suite May 6, 2024 03:44 — with GitHub Actions Inactive
@farshidz farshidz temporarily deployed to marqo-test-suite May 6, 2024 03:44 — with GitHub Actions Inactive
@farshidz farshidz temporarily deployed to marqo-test-suite May 6, 2024 03:44 — with GitHub Actions Inactive
@farshidz farshidz temporarily deployed to marqo-test-suite May 6, 2024 03:44 — with GitHub Actions Inactive
@farshidz farshidz temporarily deployed to marqo-test-suite May 6, 2024 03:44 — with GitHub Actions Inactive
@wanliAlex wanliAlex merged commit a7adfa0 into mainline May 6, 2024
23 of 25 checks passed
@wanliAlex wanliAlex deleted the li/fix-image-repo branch May 6, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants