Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch image download with invalid _id #860

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Conversation

wanliAlex
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    A 500 error is returned if a document with invalid _id is indexed to an image index.

E.g., creating an index with treat_urls_and_pointers_as_image=True and indexing this document
{"_id": 123, "image_field": "https://a-url-to-image/image1.jpg"}
with give you a 500 error.

  • What is the new behavior (if this is a feature change)?
    only 400 is returned for the document with an invalid id. The other documents in the batch will be indexed as expected.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    no

  • Related Python client changes (link commit/PR here)
    no

  • Related documentation changes (link commit/PR here)
    no

  • Other information:
    no

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@wanliAlex wanliAlex merged commit cafe92e into mainline Jun 13, 2024
27 of 28 checks passed
@wanliAlex wanliAlex deleted the li/patch-image-download branch June 13, 2024 07:31
wanliAlex added a commit that referenced this pull request Jun 13, 2024
Patch the image download when there is an invalid _id in the documents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants