-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Marqo Document API Response Format #911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
had a problem deploying
to
marqo-test-suite
July 19, 2024 08:09
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
July 22, 2024 01:34
— with
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
July 22, 2024 02:22
— with
GitHub Actions
Inactive
farshidz
requested changes
Jul 22, 2024
wanliAlex
had a problem deploying
to
marqo-test-suite
July 22, 2024 06:18
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
July 22, 2024 06:28
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
July 22, 2024 06:38
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
July 22, 2024 06:41
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
July 23, 2024 10:22
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
July 23, 2024 10:26
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
July 23, 2024 10:37
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
July 24, 2024 02:44
— with
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 00:31
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 00:34
— with
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
August 2, 2024 00:46
— with
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 00:51
— with
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
August 2, 2024 00:51
— with
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 00:51
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 00:51
— with
GitHub Actions
Inactive
papa99do
reviewed
Aug 2, 2024
papa99do
previously approved these changes
Aug 2, 2024
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 01:43
— with
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
August 2, 2024 01:45
— with
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 02:10
— with
GitHub Actions
Inactive
farshidz
reviewed
Aug 2, 2024
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 02:44
— with
GitHub Actions
Inactive
farshidz
approved these changes
Aug 2, 2024
farshidz
temporarily deployed
to
marqo-test-suite
August 2, 2024 03:09
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 03:33
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
August 2, 2024 05:13
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When we feed a batch of documents to Vespa, if there is an http error (e.g., time out error) for one document, the request will raise a 500 error without the status of each document. This could be a transient network issue that only happens to one document while other documents are indexed into Vespa. We modify the error message logic to better demonstrate the indexing results.
What is the new behavior (if this is a feature change)?
In this PR, we update the Marqo document API format. Each document will have its individual response status for batch requests (update documents, add documents, get_documents_by_ids). For example, if a single document fails due to a transient network issue, we still return 200 for the whole batch response, but 500 for the specific document.
We also include the failure count, error count, and success count in the returned response's header for SLA purpose.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Have unit tests been run against this PR? (Has there also been any additional testing?)
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements