Fix embed not using cuda as default device when available 2.11 #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
reviewed
Aug 19, 2024
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
requested changes
Aug 20, 2024
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
changed the title
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
previously approved these changes
Aug 20, 2024
farshidz
previously approved these changes
Aug 20, 2024
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
when device is unset in the embed request, even though cuda is available, default device of embed is cpu. Other functionalities such as search, add docs are unaffected (defaults to cuda when available)
What is the new behavior (if this is a feature change)?
default device in embed will be cuda when it is avialable
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Have unit tests been run against this PR? (Has there also been any additional testing?)
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements