Extract test image urls to marqo_test.py #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
force-pushed
the
yihan/use-smaller-images
branch
from
2ba27dd to
6480077
Compare
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
force-pushed
the
yihan/use-smaller-images
branch
from
4a2e230 to
042fd4f
Compare
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
reviewed
Sep 12, 2024
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
force-pushed
the
yihan/use-smaller-images
branch
from
dad8b31 to
825ce22
Compare
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
reviewed
Sep 16, 2024
papa99do
force-pushed
the
yihan/use-smaller-images
branch
from
07329fe to
465f87b
Compare
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
force-pushed
the
yihan/use-smaller-images
branch
from
24b8607 to
15d5aa0
Compare
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
vicilliar
approved these changes
Sep 17, 2024
adityabharadwaj198
pushed a commit
to adityabharadwaj198/marqo
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test improvements
What is the current behavior? (You can also link to an open issue here)
We use various images in tests. URLs of the image are defined in each individual tests
What is the new behavior (if this is a feature change)?
We consolidate these URLs to a dict maintained in marqo_test.py so that we can change them in a central place in the future.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes
Related Python client changes (link commit/PR here)
N/A
Related documentation changes (link commit/PR here)
N/A
Other information:
N/A
Please check if the PR fulfills these requirements